Format number for The Netherlands #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
goveo
approved these changes
May 18, 2024
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @jessetan! I'm facing an issue with validating numbers starting from '097'. We're using your phone input to get OTPs and we have users worldwide. But due to formatting numbers like this ( It is said that these numbers are M2M numbers but there are mentions of numbers like the following which say these are being used to get SMS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
The default formatting for phone number from the Netherlands used the format
.. ......... That is, a two digit area code followed by the rest of the number.However area codes can be either two or three digits (plus one if you count the optional
0which should be omitted in E.164 notation).A full list from the Dutch government is here: https://wetten.overheid.nl/jci1.3:c:BWBR0010198&bijlage=1&z=2022-12-16&g=2022-12-16
The majority of the area codes are three digits and a smaller number have two digits. Notable exceptions are mobile numbers, which always start with
6.This PR adds formatting for all one and two digit area codes, as well as one, two and three digit area codes with the optional leading
0. If no area code matches, it is assumed to be a three digit area code without leading0.Checklist before requesting a review
Screenshots (if appropriate):